Differential D16179

compare with QLatin1String and harmonize handling of all types
ClosedPublic
Actions

Authored by astippich on Oct 13 2018, 4:59 PM.

Details

Reviewers
mgallien
bruns
Commits
R286:fd9ce3a4e1d2: compare with QLatin1String and harmonize handling of all types
Summary

small optimization and harmonization for all metadata formats in taglibextractor

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Oct 13 2018, 4:59 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 13 2018, 4:59 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Oct 13 2018, 4:59 PM
bruns accepted this revision.Oct 17 2018, 6:33 PM

Preferably, do such independent changes (restructuring, coding style/optimization) as two separate reviews.

This revision is now accepted and ready to land.Oct 17 2018, 6:33 PM
Closed by commit R286:fd9ce3a4e1d2: compare with QLatin1String and harmonize handling of all types (authored by astippich). · Explain WhyOct 17 2018, 6:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/extractors/taglibextractor.cpp (41 lines)

Diff 43818

View Options

src/extractors/taglibextractor.cpp

Loading...