WIP: Add the transposed aspect ratio of current image to combobox
Needs ReviewPublic

Authored by gregormi on Oct 13 2018, 7:58 AM.

Details

Reviewers
None
Group Reviewers
Gwenview
Summary

Notes beforehand: There are issues with this proposal:

  • The addition of the aspect ratio to the combobox items (1.)... a) makes it larger than necessary, b) might not useful in the general case where image dimensions does not fit "good" numbers.
    • This part should therefore be probably dropped.
  • The variable addition of "Current image" to the appropriate sections (2.)... might break the persistence of the last used value.

(1. Adds the actual aspect ratio to the "Current Image" item in the combobox of crop aspect ratios)

  1. Adds the transposed aspect ratio to the appropriate section (Landscape or Portrait)

So, if we have a landscape 4:3 image, then instead of "Current Image", the item text is now "Current Image (4:3)".
Additionally, in the Portrait section we have a new item with the transposed aspect ratio: "Current Image (3:4)".
If the image was portrait (3:4), then the transposed item "Current Image (4:3)" would be located in the Landscape section.

Screenshots:

BEFORE:

AFTER:

a landscape image (4:3):

a portrait image (with uncommon aspect ratio):

Diff Detail

Repository
R260 Gwenview
Branch
my_crop_combo
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3833
Build 3851: arc lint + arc unit
gregormi created this revision.Oct 13 2018, 7:58 AM
Restricted Application added a project: Gwenview. ยท View Herald TranscriptOct 13 2018, 7:58 AM
gregormi requested review of this revision.Oct 13 2018, 7:58 AM
gregormi retitled this revision from Add the transposed aspect ratio of current image to combobox to WIP: Add the transposed aspect ratio of current image to combobox.Oct 13 2018, 8:06 AM
gregormi edited the summary of this revision. (Show Details)
gregormi edited the summary of this revision. (Show Details)Oct 13 2018, 8:09 AM
gregormi edited the summary of this revision. (Show Details)Oct 13 2018, 8:14 AM
gregormi edited the summary of this revision. (Show Details)
gregormi edited the summary of this revision. (Show Details)Oct 13 2018, 8:49 AM
gregormi edited the summary of this revision. (Show Details)Oct 13 2018, 12:17 PM