Differential D16150

Add Messages.sh for KIO slave
ClosedPublic
Actions

Authored by broulik on Oct 12 2018, 7:00 AM.

Details

Reviewers
aacid
pino
Commits
R370:467ad9f7e017: Add Messages.sh
Test Plan

This could go into stable branch, I guess?

Diff Detail

Repository
R370 Kamera
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik requested review of this revision.Oct 12 2018, 7:00 AM
broulik created this revision.
pino added a subscriber: pino.Oct 12 2018, 7:06 AM

Even if the kioslave is still called "kio_kamera", and not installed in a kf5-specific directory, can you please use "kio5_kamera" as catalog name?
This way it will be slightly more future-proof, and one step less from potential parallel installation with a future KF6.

pino added a comment.Oct 12 2018, 7:06 AM

This could go into stable branch, I guess?

Definitely.

broulik updated this revision to Diff 43441.Oct 12 2018, 7:22 AM
  • Use kio5 prefix
pino accepted this revision.Oct 12 2018, 7:43 AM

to Applications/18.08 please :)

This revision is now accepted and ready to land.Oct 12 2018, 7:43 AM
Closed by commit R370:467ad9f7e017: Add Messages.sh (authored by broulik). · Explain WhyOct 12 2018, 8:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkioslave/CMakeLists.txt (2 lines)
AMkioslave/Messages.sh (2 lines)

Diff 43448

View Options

kioslave/CMakeLists.txt

Loading...
View Options

kioslave/Messages.sh

Loading...