Details

Reviewers

tcanabrava
rizzitello

Commits

R337:9d028a06f6a9: Change null pointer reference from zero to nullptr

Diff Detail

Repository

R337 KTurtle

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Shroudmaster created this revision.Oct 11 2018, 10:20 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 11 2018, 10:20 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

Shroudmaster requested review of this revision.Oct 11 2018, 10:20 PM

Harbormaster completed remote builds in B3777: Diff 43431.Oct 11 2018, 10:20 PM

Check your Indentation you seam to have moved all your modified lines in a bit.

src/editor.cpp
427	In this situation we can do this. if (pointer) { pointer is something } else { pointer is null } since any non 0 value is true if your pointer has be initialized will be "true"

This revision now requires changes to proceed.Oct 12 2018, 1:35 AM

Fixed the indentation and conditional

Harbormaster completed remote builds in B3803: Diff 43483.Oct 12 2018, 4:58 PM

rizzitello requested changes to this revision.Oct 12 2018, 5:20 PM

rizzitello added inline comments.

src/mainwindow.cpp
139	Missed one

This revision now requires changes to proceed.Oct 12 2018, 5:20 PM

Third time is the charm!

Harbormaster completed remote builds in B3813: Diff 43496.Oct 12 2018, 6:42 PM

rizzitello requested changes to this revision.Oct 12 2018, 6:52 PM

rizzitello added inline comments.

src/mainwindow.cpp
139	check your logic here. Pretty sure we want if(!colorPicker) here

This revision now requires changes to proceed.Oct 12 2018, 6:52 PM

Sorry, innocent mistake

Harbormaster completed remote builds in B3820: Diff 43504.Oct 12 2018, 6:59 PM

Much Nicer !

This revision is now accepted and ready to land.Oct 12 2018, 8:01 PM

Oh you're doing this manually?

You really want to be using a tool for this

https://www.kdab.com/clang-tidy-part-1-modernize-source-code-using-c11c14/

has some example of how to use clang-tidy to run the modernize-use-nullptr "checker"

Sorry, it seems I forgot a file before

Harbormaster completed remote builds in B3830: Diff 43514.Oct 12 2018, 10:38 PM

tcanabrava accepted this revision.Oct 13 2018, 7:02 PM

Closed by commit R337:9d028a06f6a9: Change null pointer reference from zero to nullptr (authored by Shroudmaster, committed by tcanabrava). · Explain WhyOct 13 2018, 7:03 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/canvas.cpp (2 lines)
M			src/editor.cpp (12 lines)
M			src/errordialog.cpp (8 lines)
M			src/highlighter.cpp (12 lines)
M			src/inspector.cpp (10 lines)
M			src/main.cpp (4 lines)
M			src/mainwindow.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43431	3ee5bfb		Oct 11 2018, 10:20 PM	★	★
Diff 2	43483	3ee5bfb	Fixed the indentation and conditional	Oct 12 2018, 4:58 PM	★	★
Diff 3	43496	3ee5bfb	Third time is the charm!	Oct 12 2018, 6:42 PM	★	★
Diff 4	43504	3ee5bfb	Sorry, innocent mistake	Oct 12 2018, 6:58 PM	★	★
Diff 5	43514	3ee5bfb	Sorry, it seems I forgot a file before	Oct 12 2018, 10:37 PM	★	★
Diff 6	43551	3ee5bfb	R337:9d028a06f6a9ed9967bb46e07d40d81bb67c758d	Oct 13 2018, 7:03 PM	★	★

Change null pointer reference from zero to nullptr
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 43551

src/canvas.cpp

src/editor.cpp

src/errordialog.cpp

src/highlighter.cpp

src/inspector.cpp

src/main.cpp

src/mainwindow.cpp

Change null pointer reference from zero to nullptrClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 43551

src/canvas.cpp

src/editor.cpp

src/errordialog.cpp

src/highlighter.cpp

src/inspector.cpp

src/main.cpp

src/mainwindow.cpp

Change null pointer reference from zero to nullptr
ClosedPublic
Actions

Revision Contents
Changeset List