Differential D16122

[App] Always show drawer on Desktop
ClosedPublic
Actions

Authored by nicolasfella on Oct 10 2018, 10:35 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R224:7307cd2709a6: [App] Always show drawer on Desktop
Summary

A drawer is not good UX on the desktop. Only collapse it when on mobile or window is very narrow

Test Plan


Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Oct 10 2018, 10:35 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptOct 10 2018, 10:35 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Oct 10 2018, 10:35 PM
nicolasfella edited the test plan for this revision. (Show Details)Oct 10 2018, 10:36 PM
nicolasfella edited the test plan for this revision. (Show Details)Oct 10 2018, 10:38 PM
albertvaka accepted this revision.Oct 11 2018, 12:47 PM
albertvaka added a subscriber: albertvaka.

Makes sense. Why isn't this the default behavior?

This revision is now accepted and ready to land.Oct 11 2018, 12:47 PM
Closed by commit R224:7307cd2709a6: [App] Always show drawer on Desktop (authored by nicolasfella). · Explain WhyOct 11 2018, 2:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapp/qml/main.qml (3 lines)

Diff 43393

View Options

app/qml/main.qml

Loading...