Differential D16121

Make sure the card we're trying to automove is the top of the pile
ClosedPublic
Actions

Authored by aacid on Oct 10 2018, 10:19 PM.

Details

Reviewers
shlomif
fabiank
Group Reviewers
KDE Games
Commits
R410:925769b482e5: Make sure the card we're trying to automove is the top of the pile
Summary

Matches the check of DealerScene::tryAutomaticMove

BUGS: 399123

Diff Detail

Repository
R410 KPatience
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Oct 10 2018, 10:19 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptOct 10 2018, 10:19 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
aacid requested review of this revision.Oct 10 2018, 10:19 PM
shlomif added a comment.Oct 11 2018, 10:42 AM

Can you give a deal number / screenshot / screencast where kpat moves a non-top card to the foundation automatically without this patch?

aacid added a comment.Oct 11 2018, 10:16 PM
In D16121#341203, @shlomif wrote:

Can you give a deal number / screenshot / screencast where kpat moves a non-top card to the foundation automatically without this patch?

Yes, as you can read the bug the only thing you need is have a pile where the last N cards are "correct", e.g. Red J and Black 10, then double click on the Red J and see how it goes to the top left.

shlomif accepted this revision.Oct 12 2018, 8:11 AM
In D16121#341556, @aacid wrote:
In D16121#341203, @shlomif wrote:

Can you give a deal number / screenshot / screencast where kpat moves a non-top card to the foundation automatically without this patch?

Yes, as you can read the bug the only thing you need is have a pile where the last N cards are "correct", e.g. Red J and Black 10, then double click on the Red J and see how it goes to the top left.

Thanks! I see it here now - https://bugs.kde.org/show_bug.cgi?id=399123 - there was no link to the bug. The fix seems sane.

This revision is now accepted and ready to land.Oct 12 2018, 8:11 AM
fabiank accepted this revision.Oct 12 2018, 9:11 AM
aacid added a comment.Oct 12 2018, 10:34 AM
In D16121#341752, @shlomif wrote:

Thanks! I see it here now - https://bugs.kde.org/show_bug.cgi?id=399123 - there was no link to the bug. The fix seems sane.

It says

BUGS: 399123

on the summary ;)

Closed by commit R410:925769b482e5: Make sure the card we're trying to automove is the top of the pile (authored by aacid). · Explain WhyOct 12 2018, 10:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mfreecell.cpp (3 lines)

Diff 43452

View Options

freecell.cpp

Loading...