Paste plain text as selected text style on SVG text tool
ClosedPublic

Authored by mscaliskan on Oct 10 2018, 9:23 PM.

Details

Summary

Paste plain text as selected text style, although all text selected on rich text window on SVG text tool.


BUG: 392356

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mscaliskan requested review of this revision.Oct 10 2018, 9:23 PM
mscaliskan created this revision.
dkazakov accepted this revision.Oct 10 2018, 9:44 PM
dkazakov added a subscriber: dkazakov.

Hi, @mscaliskan!

The patch looks fine! Please write me you email to dimula73 "at" gmail.com, so I could push your patch under your full name!

This revision is now accepted and ready to land.Oct 10 2018, 9:44 PM
This revision was automatically updated to reflect the committed changes.
shubham added inline comments.
plugins/tools/svgtexttool/SvgRichTextCtrl.cpp
1

Where is the copyright header?

Hi @shubham

Sorry, this is my first open source project contribution, I forgot to add one. And, I don't know how it is written. I can copy from an other file but, whose e-mail should be written on top, mine, dkazakov or both ?

And should I reopen this revision (it is already committed) or create a new one?

Reopen this one, copy the header from other file, change the name, email to yours and year to 2018

plugins/tools/svgtexttool/SvgRichTextCtrl.h
1

Copyright header?

mscaliskan updated this revision to Diff 44031.Oct 21 2018, 4:34 PM

Copyright notices added

mscaliskan reopened this revision.Oct 21 2018, 4:43 PM

I added Copyright notices and create diff again, however, this is already committed therefore, let me know if I should create only copyright diffs.

This revision is now accepted and ready to land.Oct 21 2018, 4:43 PM
This revision was automatically updated to reflect the committed changes.