Paste plain text as selected text style, although all text selected on rich text window on SVG text tool.
BUG: 392356
Paste plain text as selected text style, although all text selected on rich text window on SVG text tool.
BUG: 392356
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Hi, @mscaliskan!
The patch looks fine! Please write me you email to dimula73 "at" gmail.com, so I could push your patch under your full name!
plugins/tools/svgtexttool/SvgRichTextCtrl.cpp | ||
---|---|---|
1 | Where is the copyright header? |
Hi @shubham
Sorry, this is my first open source project contribution, I forgot to add one. And, I don't know how it is written. I can copy from an other file but, whose e-mail should be written on top, mine, dkazakov or both ?
And should I reopen this revision (it is already committed) or create a new one?
Reopen this one, copy the header from other file, change the name, email to yours and year to 2018
plugins/tools/svgtexttool/SvgRichTextCtrl.h | ||
---|---|---|
1 | Copyright header? |
I added Copyright notices and create diff again, however, this is already committed therefore, let me know if I should create only copyright diffs.