Differential D16118

Fix crash on startup
ClosedPublic
Actions

Authored by aacid on Oct 10 2018, 9:08 PM.

Details

Reviewers
None
Group Reviewers
KDE Games
Commits
R423:ff1e5bc84151: Fix crash on startup
Summary

There was various threads using the same kconfig[group] at the same time, so bad things happened.
Add a mutex

BUGS: 398416

Test Plan

Run

rm -f ~/.config/palapeli* && palapeli

a few times, see it doesn't crash anymore

Diff Detail

Repository
R423 Palapeli
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Oct 10 2018, 9:08 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptOct 10 2018, 9:08 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
aacid requested review of this revision.Oct 10 2018, 9:08 PM
aacid added a subscriber: chehrlic.Oct 10 2018, 9:10 PM
aacid added a comment.Oct 16 2018, 5:46 PM

Unless someone disagrees i'll commit this tomorrow

This revision was not accepted when it landed; it landed in state Needs Review.Oct 17 2018, 5:32 PM
Closed by commit R423:ff1e5bc84151: Fix crash on startup (authored by aacid). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43806

View Options

src/file-io/collection.h

Loading...
View Options

src/file-io/collection.cpp

Loading...
View Options

src/file-io/components-collectionstorage.cpp

Loading...
View Options

src/file-io/components.h

Loading...