Add some unit tests for the shuffle algo.
ClosedPublic

Authored by shlomif on Oct 10 2018, 1:32 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Test Plan

test that the deals are the same

Diff Detail

Repository
R410 KPatience
Branch
update-rand-gen
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3790
Build 3808: arc lint + arc unit
shlomif created this revision.Oct 10 2018, 1:32 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptOct 10 2018, 1:32 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
shlomif requested review of this revision.Oct 10 2018, 1:32 PM
aacid added a subscriber: aacid.Oct 10 2018, 8:35 PM

Add an autotests folder?

Most apps have it that way

Add an autotests folder?

Most apps have it that way

I guess I can do that. Is it documented somewhere? The wiki link of https://community.kde.org/Guidelines_and_HOWTOs/UnitTests here - https://duckduckgo.com/?q=kde+unit+tests&ia=web seems out-of-date.

It's just that, create a folder named autotest and put the tests there :D

You can look at okular source code if you want but there's nothing really more to it

https://cgit.kde.org/okular.git/tree/autotests

It's just that, create a folder named autotest and put the tests there :D

You can look at okular source code if you want but there's nothing really more to it

https://cgit.kde.org/okular.git/tree/autotests

Thanks! I'll take a look.

shlomif updated this revision to Diff 43447.Oct 12 2018, 8:38 AM

Move under autotests per the KDE convention.

aacid accepted this revision.Oct 12 2018, 3:38 PM
This revision is now accepted and ready to land.Oct 12 2018, 3:38 PM

Can this change be applied? Is there anything else to be done?

aacid added a comment.Oct 19 2018, 8:51 PM

You're a devloper, it's been approved, just commit it.

shlomif closed this revision.Feb 19 2019, 11:35 AM

Already committed.