[effects/fadedesktop] Properly check whether given window is on a particular virtual desktop
ClosedPublic
Actions

Authored by zzag on Oct 10 2018, 1:24 PM.

Details

Reviewers

davidedmundson

Group Reviewers

KWin

Commits

Summary

In order to check whether a window is on some particular virtual
desktop, one has to use isOnDesktop.

Also, this change adds implicit support for the new virtual desktop protocol.

Test Plan

Switched between virtual desktops with a Konsole window being on all
desktops.

Repository

R108 KWin

Branch

effects-fadedesktop-dont-animate-moving-windows

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 3721
Build 3739: arc lint + arc unit

Restricted Application added a project: KWin. · View Herald TranscriptOct 10 2018, 1:24 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Oct 10 2018, 1:24 PM

This revision is now accepted and ready to land.Oct 10 2018, 1:29 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			effects/fadedesktop/package/contents/code/main.js (11 lines)
M			libkwineffects/kwineffects.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43296	3ce817a		Oct 10 2018, 1:24 PM	★	★
Diff 2	43385	07cc4b0	R108:f1968d0cd9ffb61be250fcf2aef2d1c6c93f8e99	Oct 11 2018, 1:22 PM	★	★