[Background Model] Use own QCache for thumbnails
ClosedPublic

Authored by broulik on Oct 10 2018, 9:31 AM.

Details

Summary

Previously it would use an on-disk KImageCache which would never be invalidated. Moreover, it just uses KIO::PreviewJob which does its own more clever (compares mtime and other properties) on-disk caching already.
It is using its own QCache rather than QPixmapCache to not jeopardize other caching for the potentially large wallpaper thumbnails that are only relevant while the dialog is open.

BUG: 395447
FIXED-IN: 5.15.0

Test Plan
  • Scrolled through the list, had thumbnails be generated and cached
  • If there were too many some of them were discarded and this worked without crashing

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Oct 10 2018, 9:31 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 10 2018, 9:31 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Oct 10 2018, 9:31 AM
broulik updated this revision to Diff 43275.Oct 10 2018, 9:44 AM
broulik edited the summary of this revision. (Show Details)
  • Clarify max cost
davidedmundson accepted this revision.Oct 10 2018, 10:04 AM
This revision is now accepted and ready to land.Oct 10 2018, 10:04 AM
This revision was automatically updated to reflect the committed changes.