Moved Dialog.Keys.onPressed to Dialog.mainItem.Keys.onPressed so that all tabbox skins are consistent. This fixes up/down arrow key navigation in this skin.
CCBUG: 370185
Moved Dialog.Keys.onPressed to Dialog.mainItem.Keys.onPressed so that all tabbox skins are consistent. This fixes up/down arrow key navigation in this skin.
CCBUG: 370185
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Hmm, this does not actually work for me. Seems like it logically should, but it doesn't.
I forgot to merge this after david's patch was merged. I just tested this in the Neon Beta ISO to confirm the fix still works.
I'm guessing you didn't restart the kwin_x11 --replace process after manually patching the qml file, as I believe the old version is still kwin's cache/memory. Changing to another skin and back won't reload the skin, you need to restart kwin. That or you tested without D16693 that forwards keyboard events to the qml skin.
Yeah, I was probably doing something dumb. Confirmed that this works with your test plan.
Yay! Now onto https://bugs.kde.org/show_bug.cgi?id=308331! I tried with D16897 but ran into some trouble. It works, but the keys are hardcoded rather than reading the key from the global shortcuts. What's tricky is that only the key itself should do it, not the key plus the modifier (since the user is already holding down a modifier to keep the alt-tab switcher open).