Added missing Icons to Places Panel code from KIO
ClosedPublic

Authored by alexde on Oct 9 2018, 9:52 PM.

Details

Summary

The items "Hide", "Hide Entry" and "Show All Entries" of the places panel did not have icons.
Therefor I replicated the changes for the KIO code, which I already submitted for Dolphin.

Diff Detail

Repository
R241 KIO
Branch
missingIcons (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3699
Build 3717: arc lint + arc unit
alexde created this revision.Oct 9 2018, 9:52 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 9 2018, 9:52 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
alexde requested review of this revision.Oct 9 2018, 9:52 PM
ngraham accepted this revision.Oct 9 2018, 9:58 PM

Perfect, thanks! Since you submitted a new revision rather than updating D16049, you'll want to formally Abandon that one. In the future, now that you have arc set up, to update an existing patch, just do arc diff when you're on the branch for that patch.

This revision is now accepted and ready to land.Oct 9 2018, 9:58 PM
ngraham closed this revision.Oct 9 2018, 10:01 PM