Add benevity and Amazon Smile to "Other ways to Donate"
ClosedPublic

Authored by aacid on Oct 9 2018, 9:43 PM.

Details

Summary

For those worried about linking to amazon, even FSF does at https://www.fsf.org/about/ways-to-donate/ so if the hardcore people do i think we're fine.

Test Plan

Works on my local installation.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
aacid requested review of this revision.Oct 9 2018, 9:43 PM
aacid created this revision.

Can you only use amazon.de? Or can USA people use amazon.com as well?

stikonas accepted this revision.Oct 9 2018, 9:54 PM
This revision is now accepted and ready to land.Oct 9 2018, 9:54 PM

Can you only use amazon.de? Or can USA people use amazon.com as well?

I think only amazon.de. At least amazon.co.uk doesn't work.

bcooksley accepted this revision.Oct 10 2018, 6:29 AM
bcooksley added a subscriber: bcooksley.

Content wise this looks fine to me.

Thanks for picking this up and sorting it out Albert.

On both of the Amazon links, I only get Amazon login screens. It is not possible to review this information.

(In contrast, the Benevity link leads to information accessible to the public. The description about KDE sounds good there.)

even FSF does at https://www.fsf.org/about/ways-to-donate/

They have included a disclaimer: "As an independent small publisher, the FSF discourages people from shopping at Amazon (plus, Amazon supports DRM)". Can we add something like that as well? Because I am worried about linking to Amazon.

aacid added a comment.Oct 15 2018, 8:44 PM

On both of the Amazon links, I only get Amazon login screens. It is not possible to review this information.

(In contrast, the Benevity link leads to information accessible to the public. The description about KDE sounds good there.)

even FSF does at https://www.fsf.org/about/ways-to-donate/

They have included a disclaimer: "As an independent small publisher, the FSF discourages people from shopping at Amazon (plus, Amazon supports DRM)". Can we add something like that as well? Because I am worried about linking to Amazon.

Gregor, this change has been merged. If you're interested in proposing improvements i suggest you propose a patch yourself :)