The fullscreen effect lock is purely an implementation detail of the
AnimationEffect, we don't need to have it in the public API.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Commits
- R108:5d5816be2bac: [libkwineffects] Don't expose the fullscreen effect lock to the public API
KWin still compiles.
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- dont-expose-fullscreeneffectlock
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 3691 Build 3709: arc lint + arc unit
Comment Actions
FWIW, it was a conscious decision to make it public (we should probably remove the d-pointer now it's private). There's nothing implementation detail of AnimationEffect about it, it'd work fine in any effect.
But meh, it was kinda in the wrong place if I did want to do that and it's not as useful with the way one typically writes C++ effects.
Comment Actions
I'll delete the d-pointer. Do I have to request a review for such a small change?
But meh, it was kinda in the wrong place if I did want to do that and it's not as useful with the way one typically writes C++ effects.
+