[libkwineffects] Don't expose the fullscreen effect lock to the public API
ClosedPublic

Authored by zzag on Oct 9 2018, 3:45 PM.

Details

Summary

The fullscreen effect lock is purely an implementation detail of the
AnimationEffect, we don't need to have it in the public API.

Test Plan

KWin still compiles.

Diff Detail

Repository
R108 KWin
Branch
dont-expose-fullscreeneffectlock
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 3691
Build 3709: arc lint + arc unit
zzag created this revision.Oct 9 2018, 3:45 PM
Restricted Application added a project: KWin. · View Herald TranscriptOct 9 2018, 3:45 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Oct 9 2018, 3:45 PM
davidedmundson accepted this revision.Oct 9 2018, 3:56 PM
This revision is now accepted and ready to land.Oct 9 2018, 3:56 PM
This revision was automatically updated to reflect the committed changes.

FWIW, it was a conscious decision to make it public (we should probably remove the d-pointer now it's private). There's nothing implementation detail of AnimationEffect about it, it'd work fine in any effect.

But meh, it was kinda in the wrong place if I did want to do that and it's not as useful with the way one typically writes C++ effects.

zzag added a comment.Oct 9 2018, 5:31 PM

FWIW, it was a conscious decision to make it public (we should probably remove the d-pointer now it's private). There's nothing implementation detail of AnimationEffect about it, it'd work fine in any effect.

I'll delete the d-pointer. Do I have to request a review for such a small change?

But meh, it was kinda in the wrong place if I did want to do that and it's not as useful with the way one typically writes C++ effects.

+

Do I have to request a review for such a small change?

Nah.