Added missing QStringLiteral to Dolphin code
ClosedPublic

Authored by alexde on Oct 8 2018, 6:17 PM.

Details

Summary

Changed

QIcon::fromTheme("icon")

to

QIcon::fromTheme(QStringLiteral("edit-entry"))

as discussed here.

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
alexde created this revision.Oct 8 2018, 6:17 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptOct 8 2018, 6:17 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
alexde requested review of this revision.EditedOct 8 2018, 6:17 PM

I hope creating a new revision for each patch was the right way to go! Also, I based this patch on the master branch and not on the branches, where I submitted my other patches. Looking forward to hearing your feedback!

This revision is now accepted and ready to land.Oct 8 2018, 7:22 PM
ngraham accepted this revision.Oct 8 2018, 7:24 PM

You did great! I'll land this for you later today.

Can I get an email address for you so we can properly attribute the git commit to you?

alexde added a comment.EditedOct 8 2018, 7:35 PM

You did great! I'll land this for you later today.

Wasn't too difficult. Thanks Nate! I am already looking forward to getting more familiar with the KDE source codes.

Can I get an email address for you so we can properly attribute the git commit to you?

Sure: postix ät posteo [dot] net

ngraham closed this revision.Oct 9 2018, 9:20 PM