The items "Hide", "Hide Entry" and "Show All Entries" of the places panel did not have icons.
Therefor I replicated the changes for the KIO code, which I already submitted for Dolphin.
Details
Details
- Reviewers
ngraham - Group Reviewers
VDG Frameworks
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
This doesn't apply cleanly:
Checking patch src/filewidgets/kfileplacesview.cpp...
Hunk #1 succeeded at 745 (offset 3 lines).
error: while searching for:
add = menu.addAction(QIcon::fromTheme(QStringLiteral("document-new")), i18n("Add Entry..."));
}
hide = menu.addAction(i18n("&Hide Entry '%1'", label));
hide->setCheckable(true);
hide->setChecked(placesModel->isHidden(index));
// if a parent is hidden no interaction should be possible with children, show it first to do so
error: patch failed: src/filewidgets/kfileplacesview.cpp:778
Hunk #3 succeeded at 802 (offset 12 lines).
Applying patch src/filewidgets/kfileplacesview.cpp with 1 reject...
Hunk #1 applied cleanly.
Rejected hunk #2.
Hunk #3 applied cleanly.
Patch Failed!
Usage Exception: Unable to apply patch!Can you rebase the patch on master?
Also, you might want to set up arc, which makes it much simpler and faster to submit patches, and easier for me too. https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
Comment Actions
Also, you might want to set up arc, which makes it much simpler and faster to submit patches, and easier for me too.
I tried it again, but I forgot to add the "Differential Revision" and did not expect arc diff to automatically upload the diff. That is why you will find the new revision here: https://phabricator.kde.org/D16091
Sorry for the inconveniences I caused.
Comment Actions
No problem at all, just Abandon this one (available via the Add Action... button on the bottom of the page.