[Device Notifier] Auto-hide popup after device is unmounted
ClosedPublic
Actions

Authored by thsurrel on Oct 8 2018, 12:29 PM.

Details

Reviewers

Group Reviewers

Plasma
VDG

Commits

R120:ddebf50ea2f3: Merge remote-tracking branch 'origin/Plasma/5.14'
R120:581889351e09: [Device Notifier] Auto-hide popup after device is unmounted

Summary

When unmounting a removable device from dolphin, the device notifier
will popup saying the device can now be safely removed. But the popup
never auto-hides.

Test Plan

Plug a USB pen drive
Unmount it from dolpin
Device notifier should popup and hide itself after 3 seconds

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

thsurrel created this revision.Oct 8 2018, 12:29 PM

Restricted Application added a project: Plasma. · View Herald TranscriptOct 8 2018, 12:29 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Harbormaster completed remote builds in B3639: Diff 43129.Oct 8 2018, 12:29 PM

thsurrel requested review of this revision.Oct 8 2018, 12:29 PM

Good idea

applets/devicenotifier/package/contents/ui/devicenotifier.qml
194	Can it be `fullRepresentation` is not created at this point yet? Perhaps put it after `expanded = true`

Fix as per broulik comments. Thanks!

Harbormaster completed remote builds in B3641: Diff 43133.Oct 8 2018, 2:25 PM

thsurrel marked an inline comment as done.Oct 8 2018, 2:25 PM

I think this could go into Plasma/5.14 branch (and then merge into master)

This revision is now accepted and ready to land.Oct 8 2018, 2:26 PM

Closed by commit R120:581889351e09: [Device Notifier] Auto-hide popup after device is unmounted (authored by thsurrel). · Explain WhyOct 8 2018, 2:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			applets/devicenotifier/package/contents/ui/devicenotifier.qml (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43129	7b6b46b		Oct 8 2018, 12:29 PM	★	★
Diff 2	43133	7b6b46b	Fix as per broulik comments. Thanks!	Oct 8 2018, 2:25 PM	★	★
Diff 3	43134	a40d952	R120:581889351e096b5b9190945ec24c10e516db30be	Oct 8 2018, 2:31 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
75715f714b30	88903127054e	7b6b46bcb3ac	Thomas Surrel	[Device Notifier] Auto-hide popup after device is unmounted (Show More…)	Oct 8 2018, 12:22 PM

Diff 43134

View Options

applets/devicenotifier/package/contents/ui/devicenotifier.qml