Differential D16038

Allow dictionary runner to search multiple times
ClosedPublic
Actions

Authored by McPain on Oct 8 2018, 8:36 AM.

Details

Reviewers
jriddell
broulik
mart
Group Reviewers
Plasma
Commits
R114:04dff1e01632: Allow dictionary runner to search multiple times
Summary

Any time we search a word definition we add a source to our match engine but we never remove it.

Test Plan
  1. Open krunner
  2. Search a word definition
  3. Close krunner
  4. Open krunner
  5. Search the same word definition one more time

Expected result: the definition appears again
Actual result: there are no definitions shown.

Diff Detail

Repository
R114 Plasma Addons
Lint
Lint Skipped
Unit
Unit Tests Skipped
McPain created this revision.Oct 8 2018, 8:36 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 8 2018, 8:36 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
McPain requested review of this revision.Oct 8 2018, 8:37 AM
mart accepted this revision.Nov 23 2018, 2:14 PM
This revision is now accepted and ready to land.Nov 23 2018, 2:14 PM
Closed by commit R114:04dff1e01632: Allow dictionary runner to search multiple times (authored by McPain, committed by aacid). · Explain WhyJan 16 2019, 11:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43110

View Options

runners/dictionary/dictionarymatchengine.h

Loading...
View Options

runners/dictionary/dictionarymatchengine.cpp

Loading...