Differential D16035

[SDDM theme] Use grammatically correct string "Log In"
ClosedPublic
Actions

Authored by ngraham on Oct 8 2018, 4:28 AM.

Details

Reviewers
abetts
Group Reviewers
VDG
Plasma
Commits
R120:817f51d88237: [SDDM theme] Use grammatically correct string "Log In"
Summary

"Login" is a noun: "I have a login for the system." This is not appropriate for a button title that is used as an action; the correct verb-based string is "Log In".

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 8 2018, 4:28 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 8 2018, 4:28 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 8 2018, 4:28 AM
ngraham edited the test plan for this revision. (Show Details)Oct 8 2018, 4:30 AM
abetts accepted this revision as: VDG, abetts.Oct 9 2018, 11:08 PM
abetts added a subscriber: abetts.

+1

This revision is now accepted and ready to land.Oct 9 2018, 11:08 PM
ngraham updated this revision to Diff 43258.Oct 10 2018, 1:52 AM

Update one more occurrence

Closed by commit R120:817f51d88237: [SDDM theme] Use grammatically correct string "Log In" (authored by ngraham). · Explain WhyOct 10 2018, 1:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msddm-theme/Login.qml (2 lines)
Msddm-theme/Main.qml (2 lines)

Diff 43259

View Options

sddm-theme/Login.qml

Loading...
View Options

sddm-theme/Main.qml

Loading...