Change "hint" to "visibility-hidden" and "visiblity" to "visibility-visible"
AbandonedPublic
Actions

Authored by ngraham on Oct 7 2018, 8:18 PM.

Details

Reviewers

None

Group Reviewers

VDG
Breeze

Summary

This patch renames these icons so that their names follow the convention and bear some connection to what they look like and are for.

Compatibility symlinks are put in place so that no icon changes are required for existing software.

Test Plan

Icons for the Hidden Files actions in Dolphin remain the same

Diff Detail

Repository

R266 Breeze Icons

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3609
Build 3627: arc lint + arc unit

ngraham created this revision.Oct 7 2018, 8:18 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptOct 7 2018, 8:18 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ngraham requested review of this revision.Oct 7 2018, 8:18 PM

Harbormaster completed remote builds in B3608: Diff 43080.Oct 7 2018, 8:18 PM

Do it right

Harbormaster completed remote builds in B3609: Diff 43081.Oct 7 2018, 8:23 PM

For some reason arc doesn't want to apply this:

Checking patch dev/null => icons-dark/actions/22/hint.svg...
error: dev/null: does not exist in index
Checking patch icons-dark/actions/16/hint.svg => icons-dark/actions/16/visibility-visible.svg...
Checking patch dev/null => icons-dark/actions/16/visibility.svg...
error: dev/null: does not exist in index

Giving up, too frustrating and I've got other things to do

ngraham mentioned this in D16019: Added missing icons to panel places items.Oct 7 2018, 8:32 PM

Revision Contents
Changeset List

		Path
P	M	icons-dark/actions/16/hint.svg (1 line) Copied to icons-dark/actions/16/visibility-visible.svg
P		icons-dark/actions/16/visibility-hidden.svg (21 lines) Copied from icons-dark/actions/16/visibility.svg
P		icons-dark/actions/16/visibility-visible.svg (13 lines) Copied from icons-dark/actions/16/hint.svg
M	M	icons-dark/actions/16/visibility.svg (1 line)
P	M	icons-dark/actions/22/hint.svg (1 line) Copied to icons-dark/actions/22/visibility-visible.svg
P		icons-dark/actions/22/visibility-hidden.svg (14 lines) Copied from icons-dark/actions/22/visibility.svg
P		icons-dark/actions/22/visibility-visible.svg (14 lines) Copied from icons-dark/actions/22/hint.svg
M	M	icons-dark/actions/22/visibility.svg (1 line)
P	M	icons-dark/actions/24/hint.svg (1 line) Copied to icons-dark/actions/24/visibility-visible.svg
P		icons-dark/actions/24/visibility-hidden.svg (13 lines) Copied from icons-dark/actions/24/visibility.svg
P		icons-dark/actions/24/visibility-visible.svg (13 lines) Copied from icons-dark/actions/24/hint.svg
M	M	icons-dark/actions/24/visibility.svg (1 line)
P	M	icons/actions/16/hint.svg (1 line) Copied to icons/actions/16/visibility-visible.svg
P		icons/actions/16/visibility-hidden.svg (21 lines) Copied from icons/actions/16/visibility.svg
P		icons/actions/16/visibility-visible.svg (13 lines) Copied from icons/actions/16/hint.svg
M	M	icons/actions/16/visibility.svg (1 line)
P	M	icons/actions/22/hint.svg (1 line) Copied to icons/actions/22/visibility-visible.svg
P		icons/actions/22/visibility-hidden.svg (14 lines) Copied from icons/actions/22/visibility.svg
P		icons/actions/22/visibility-visible.svg (14 lines) Copied from icons/actions/22/hint.svg
M	M	icons/actions/22/visibility.svg (1 line)
P	M	icons/actions/24/hint.svg (1 line) Copied to icons/actions/24/visibility-visible.svg
P		icons/actions/24/visibility-hidden.svg (13 lines) Copied from icons/actions/24/visibility.svg
P		icons/actions/24/visibility-visible.svg (13 lines) Copied from icons/actions/24/hint.svg
M	M	icons/actions/24/visibility.svg (1 line)