Differential D16021

Template Files No Longer Added to 'Recent Documents' List on the Krita Greeting Page
ClosedPublic
Actions

Authored by eoinoneill on Oct 7 2018, 4:41 PM.

Details

Reviewers
rempt
dkazakov
Group Reviewers
Krita
Summary

Addressing BUG:398877, Template files will no longer show up in the 'recently opened file list' within Krita's greeter, which should prevent any potential case of unintentionally modifying template files.

Test Plan
  • Check to make sure templates never show up within the 'recently opened' files prompt.
  • Check for any potential case for false positives (or something of that sort) preventing legitimate files from being added to recently opened.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
eoinoneill created this revision.Oct 7 2018, 4:41 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptOct 7 2018, 4:41 PM
Restricted Application edited projects, added Krita; removed Krita: Abyss. · View Herald Transcript
eoinoneill requested review of this revision.Oct 7 2018, 4:41 PM
rempt added inline comments.Oct 7 2018, 4:44 PM
libs/ui/KisMainWindow.cpp
726

Maybe a good idea to add a break here, one is enough.

libs/ui/KisWelcomePageWidget.cpp
40 ↗(On Diff #43054)

These changes don't look related?

eoinoneill updated this revision to Diff 43063.Oct 7 2018, 5:03 PM

Added the break, removed unrelated formatting changes.

rempt accepted this revision.Oct 7 2018, 7:12 PM
This revision is now accepted and ready to land.Oct 7 2018, 7:12 PM
eoinoneill closed this revision.Oct 30 2018, 1:34 AM
eoinoneill marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
Mlibs/ui/KisMainWindow.cpp (8 lines)

Diff 43063

View Options

libs/ui/KisMainWindow.cpp

Loading...