Differential D16014

Give ActionButton an optional and off-by-default drop shadow
AbandonedPublic
Actions

Authored by ngraham on Oct 7 2018, 2:05 PM.

Details

Reviewers
None
Group Reviewers
Plasma
VDG
Maniphest Tasks
T9658: Rethink blur-by-default for Breeze SDDM login screen theme for Plasma 5.15
Summary

ActionButton's text can be difficult to see when the background is light-colored or very busy (This is also true of the icon, which will be dealt with in another patch).

For clients that may put an ActionButton on top of such a background, this patch allows the client to add a drop shadow to the text to improve contrast and reabability. It is off by default.

Test Plan

No visual change for any current clients (login screen, lock screen, logout screen)

Here is what it would look like if enabled:

Diff Detail

Repository
R120 Plasma Workspace
Branch
actionbutton-optional-label-shadow (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3612
Build 3630: arc lint + arc unit
ngraham created this revision.Oct 7 2018, 2:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 7 2018, 2:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 7 2018, 2:05 PM
ngraham edited the summary of this revision. (Show Details)Oct 7 2018, 2:10 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)Oct 7 2018, 8:49 PM
ngraham updated this revision to Diff 43084.Oct 7 2018, 8:55 PM

Automatically use an appropriate color from the color scheme instead of hardcoding black and allowing it to be overridable

ngraham abandoned this revision.Oct 7 2018, 9:28 PM
ngraham removed a dependent revision: D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

Collapsed changes into D16031; no need to have it separate here.

mart added a subscriber: mart.Oct 8 2018, 8:32 AM

Question: how are the icons done?
i think the circle should *not* be in the icon graphics, but in the qml part

ngraham added a comment.Oct 8 2018, 8:14 PM
In D16014#338952, @mart wrote:

Question: how are the icons done?

See D15999: Add icons with added background to system.svgz

i think the circle should *not* be in the icon graphics, but in the qml part

This was discussed extensively in T9444: Improve contrast and selection state of action buttons on login, lock, and logout screens. In particular, please read https://phabricator.kde.org/T9444#160048

Revision Contents
Changeset List

Diff 43084

View Options

lookandfeel/contents/components/ActionButton.qml

Loading...