Differential D16006

Fix disabling of DolphinNewFileMenu
ClosedPublic
Actions

Authored by elvisangelaccio on Oct 7 2018, 11:27 AM.

Details

Reviewers
ngraham
Group Reviewers
Dolphin
Commits
R318:5e8b892a519b: Fix disabling of DolphinNewFileMenu
Summary

Commit e133c4557ecc37ed3f7e1b9 doesn't work because the actions in the
KNewFileMenu are added only when we show the context menu for the first
time.

Fixes the failing test cases in D16005.

Test Plan

Run dolphinmainwindowtest and open the context menu in different places (Home, Root, Trash, bluetooth:/, etc.)

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Dolphin. · View Herald TranscriptOct 7 2018, 11:27 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Oct 7 2018, 11:27 AM
ngraham accepted this revision.Oct 7 2018, 1:18 PM
ngraham added a subscriber: ngraham.

Oops, guess I didn't test this enough, sorry about that! :/

Thanks for cleaning up my mess, Elvis.

This revision is now accepted and ready to land.Oct 7 2018, 1:18 PM
Closed by commit R318:5e8b892a519b: Fix disabling of DolphinNewFileMenu (authored by elvisangelaccio). · Explain WhyOct 7 2018, 2:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/dolphinmainwindow.cpp (11 lines)

Diff 43046

View Options

src/dolphinmainwindow.cpp

Loading...