QUrl.toString() is not a valid local file
ClosedPublic
Actions

Authored by tcanabrava on Oct 7 2018, 10:35 AM.

Details

Reviewers

rizzitello
patrickelectric

Commits

Summary

A file schema started with file:// is invalid inside QFileInfo, the test was always false.

Repository

R231 Atelier

Branch

arcpatch-D16002

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4076
Build 4094: arc lint + arc unit

tcanabrava requested review of this revision.Oct 7 2018, 10:35 AM

tcanabrava created this revision.

This seamed to work correctly. You may wish to check for other instances of this in Atelier.

pino added inline comments.

src/widgets/atcoreinstancewidget.cpp
331	this one too?

src/widgets/atcoreinstancewidget.cpp
331	Yes that one too. Also mainwindow.cpp L#255 mainwindow.cpp L#322

This revision is now accepted and ready to land.Oct 13 2018, 6:59 PM

			Path	Packages
M			src/mainwindow.cpp (4 lines)
M			src/widgets/atcoreinstancewidget.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43014	d73b93a		Oct 7 2018, 10:35 AM	★	★
Diff 2	43968	6b69415	- Catch remaining instances of url::toString	Oct 20 2018, 2:44 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
a34726b174b3	c6672af080a3	5588da131c73	Chris Rizzitello	Catch remaining instances of url::toString (Show More…)	Oct 20 2018, 2:42 PM
5588da131c73	07167e960646	6b6941545c92	Tomaz Canabrava	QUrl.toString() is not a valid local file (Show More…)	Oct 20 2018, 2:39 PM