Differential D15998

Fix discovery of clang builtin directory with clang svn versions
ClosedPublic
Actions

Authored by buschinski on Oct 7 2018, 9:44 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:6da2caac877d: Fix discovery of clang builtin directory with clang svn versions
Summary

The CLANG_VERSION for svn clang versions have a svn suffix "8.0.0svn" and all the libraries have a svn suffix.
But not the in builtin include dir. It still points to
"/usr/lib/clang/8.0.0/include/cpuid.h"
without the suffix.

Extend the PATH_SUFFIXES to also looks a version without svn suffix.

BUG: 399439

Test Plan
  • install clang-svn
  • execute cmake .. (for kdevelop)

-> it will fail

Diff Detail

Repository
R32 KDevelop
Lint
Lint Skipped
Unit
Unit Tests Skipped
buschinski created this revision.Oct 7 2018, 9:44 AM
Restricted Application added a project: KDevelop. · View Herald TranscriptOct 7 2018, 9:44 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
buschinski requested review of this revision.Oct 7 2018, 9:44 AM
kfunk accepted this revision.Oct 7 2018, 11:51 AM
This revision is now accepted and ready to land.Oct 7 2018, 11:51 AM
buschinski closed this revision.Oct 7 2018, 1:47 PM

Revision Contents
Changeset List

PathPackages
Mcmake/modules/FindClang.cmake (5 lines)

Diff 43006

View Options

cmake/modules/FindClang.cmake

Loading...