[SMS App] Improve contact matching
ClosedPublic

Authored by sredman on Oct 6 2018, 10:30 PM.

Details

Summary

Improve contact matching by checking if the requested address ends with a candidate phone number, or vice-versa

Test Plan

Check that *all* conversations which correspond to a contact are matched

  • All of mine match. If someone finds one which doesn't, I will need the particulars...

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sredman created this revision.Oct 6 2018, 10:30 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptOct 6 2018, 10:30 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Oct 6 2018, 10:30 PM
nicolasfella requested changes to this revision.Oct 6 2018, 11:25 PM
nicolasfella added a subscriber: nicolasfella.

Works pretty good, but to make it work perfectly for me a minor change is needed. Please make canonicalizePhonenumber strip leading zeroes, else +49123456 and 0123456 wouldn't match

This revision now requires changes to proceed.Oct 6 2018, 11:25 PM
sredman updated this revision to Diff 42997.Oct 7 2018, 12:36 AM

Strip leading zeroes

sredman updated this revision to Diff 42998.Oct 7 2018, 12:36 AM

Undo committing the entire history

nicolasfella accepted this revision.Oct 7 2018, 2:31 PM
This revision is now accepted and ready to land.Oct 7 2018, 2:31 PM
This revision was automatically updated to reflect the committed changes.