[wayland] Use pending maximize mode in decoration updates
ClosedPublic

Authored by davidedmundson on Oct 6 2018, 10:02 PM.

Details

Summary

The change to make maximize mode asynchronous featured the comment

Things are a bit complex with borders. Technically we
shouldn't update them till we get a response, but we also need to have
the correct geometry of the full size window in our request. For now
they behave as before, updating when we request the change.

We call setNoBorder when we request the geometry but decoratedClient
also checks the maximise mode, in order to follow the scheme above we
need this to operate on the requested state not current state.

X is unaffected.

This fixes the borders being restored correct after maximize/restore.

Test Plan

Chose a theme with visible borders
Maximised a window and back
They restored

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Oct 6 2018, 10:02 PM
Restricted Application added a project: KWin. · View Herald TranscriptOct 6 2018, 10:02 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Oct 6 2018, 10:02 PM
zzag accepted this revision.Oct 7 2018, 7:57 AM
zzag added a subscriber: zzag.
zzag added inline comments.
abstract_client.h
468

One extra semicolon.

This revision is now accepted and ready to land.Oct 7 2018, 7:57 AM
This revision was automatically updated to reflect the committed changes.