Differential D1596

Do not limit mouse actions to titleBarArea but allow on complete titleBarPosition
ClosedPublic
Actions

Authored by graesslin on May 12 2016, 8:36 AM.

Details

Reviewers

mart

Group Reviewers

Plasma

Commits

R108:14d12c05855a: Do not limit mouse actions to titleBarArea but allow on complete…

Summary

Mouse actions like wheel and double click were restricted to the titleBar
area. This made the top most pixel non-interactive as it's not part of the
titleBarArea.

This change makes the complete titlebarPosition interactive. That is it
includes for a "normal" (top) setup also the TopLeft/Top/Right section.
Thus the top most pixel can be double clicked, mouse wheeled, etc.

For the Wayland case the test case is adjusted.

BUG: 362860
FIXED-IN: 5.7.0

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 3776.May 12 2016, 8:36 AM

graesslin retitled this revision from to Do not limit mouse actions to titleBarArea but allow on complete titleBarPosition.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptMay 12 2016, 8:36 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart accepted this revision.May 12 2016, 11:28 AM

mart added a reviewer: mart.

This revision is now accepted and ready to land.May 12 2016, 11:28 AM

Closed by commit R108:14d12c05855a: Do not limit mouse actions to titleBarArea but allow on complete… (authored by graesslin). · Explain WhyMay 12 2016, 3:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			abstract_client.h (1 line)
M			abstract_client.cpp (29 lines)
M			autotests/wayland/decoration_input_test.cpp (54 lines)
M			events.cpp (4 lines)
M			input.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3776	4f222c2		May 12 2016, 8:36 AM	★	★
Diff 2	3789	8d7d51e	rKWIN14d12c05855adb42fb572ad1c41ba2c2547765f4	May 12 2016, 2:58 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
7efccde5326c	126728b5d9df	4f222c2cdad3	Martin Gräßlin	Do not limit mouse actions to titleBarArea but allow on complete… (Show More…)	May 12 2016, 8:28 AM