Disable fade effect during fullscreen effects
ClosedPublic

Authored by davidedmundson on Oct 4 2018, 12:54 AM.

Details

Summary

This means that if one opens/closes a window whilst present windows (for
example) is active we don't have two effects meddling with the opacity.

Like glide and scale this disables if it's invoked during an active full
screen effect, but it does not cancel animations that are running when a
full screen effect is launched.

Test Plan

Windows still fade normally as before
Ran sleep ; dolphin with present windows / cube
Present windows fades windows itself so it's hard to see any difference
But it's more technically correct

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Oct 4 2018, 12:54 AM
Restricted Application added a project: KWin. · View Herald TranscriptOct 4 2018, 12:54 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Oct 4 2018, 12:54 AM
zzag accepted this revision.Oct 4 2018, 6:47 AM
zzag added a subscriber: zzag.

Please prepend "[effects/fade]" to the title.

This revision is now accepted and ready to land.Oct 4 2018, 6:47 AM
zzag added a comment.Oct 4 2018, 7:05 AM

Seems like I missed non-capitalized "screen".

Can you please capitalize "screen" at https://github.com/KDE/kwin/blob/master/libkwineffects/kwineffects.h#L828?

This revision was automatically updated to reflect the committed changes.
abetts added a subscriber: abetts.Oct 4 2018, 1:46 PM

Can you please share some examples of what this will look like? video? :D