Differential D15924

Color Dodge, and Parallel Blending Mode Fix
AbandonedPublic
Actions

Authored by Reptorian on Oct 3 2018, 4:21 PM.

Details

Reviewers
None
Group Reviewers
Krita
Summary

Blend Mode Testing.kra1 MBDownload

The file included is to test the result of blending modes. With this patch, you should not see bright colors showing up. The patch aims to make those two blending mode continuous without bright color showing up.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
Reptorian created this revision.Oct 3 2018, 4:21 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptOct 3 2018, 4:21 PM
Restricted Application added a project: Krita. · View Herald Transcript
Reptorian requested review of this revision.Oct 3 2018, 4:21 PM
rempt added a subscriber: rempt.Oct 5 2018, 7:09 AM

I thought dmitry had already accepted this patch?

rempt added a comment.Oct 7 2018, 9:42 AM

I'm getting a bit confused with the different blending mode patches -- but apart from that I'm beginning to wonder whether we should have preferences switch for enalbing "extended" blending modes, ones that are not common in other apps like gimp and photoshop, so we don't overwhelm our users :-)

Reptorian abandoned this revision.Oct 8 2018, 12:58 AM

The confusion came because this was part of the extended modes, and I asked if this should also be in it own patch, so I uploaded this one. Now I decided to abandon this as it wasn't necessary to upload this one.

Revision Contents
Changeset List

Diff 42803

View Options

libs/pigment/compositeops/KoCompositeOpFunctions.h

Loading...