Differential D15912

Don't silently error if damage is sent before buffer
ClosedPublic
Actions

Authored by davidedmundson on Oct 2 2018, 11:41 PM.

Details

Reviewers
romangg
Group Reviewers
KWin
Commits
R127:b4cd89ea4977: Don't silently error if damage is sent before buffer
Summary

Firefox sends

wl_surface@37.damage(0, 0, 808, 622)
wl_surface@37.attach(wl_buffer@34, 0, 0)

Which we silently treat as an error.

There's nothing in the spec to forbid this. The only thing that matters
is the state on commit. This moves a check there.

CCBUG: 397834

Test Plan

Had a debug in there which was being activated
Gets firefox slightly further (but not complete)

Diff Detail

Repository
R127 KWayland
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 3462
Build 3480: arc lint + arc unit
davidedmundson created this revision.Oct 2 2018, 11:41 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 2 2018, 11:41 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Oct 2 2018, 11:41 PM
romangg requested changes to this revision.Oct 2 2018, 11:55 PM
romangg added a subscriber: romangg.
romangg added inline comments.
src/server/surface_interface.cpp
461 ↗(On Diff #42766)

Unrelated change. Or split the whole case distinction directly up into:

if (target->buffer) {
    if (!target->damage.isEmpty()) {
        ...
    }
} else {
    subSurfaceIsMapped = false;
    emit q->unmapped();
}

Maybe separate patch.

This revision now requires changes to proceed.Oct 2 2018, 11:55 PM
davidedmundson updated this revision to Diff 42820.Oct 3 2018, 9:56 PM

Leave useless code in

romangg accepted this revision.Oct 3 2018, 10:38 PM

For 5.52.

This revision is now accepted and ready to land.Oct 3 2018, 10:38 PM
Closed by commit R127:b4cd89ea4977: Don't silently error if damage is sent before buffer (authored by davidedmundson). · Explain WhyOct 8 2018, 8:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/server/surface_interface.cpp (6 lines)

Diff 42820

View Options

src/server/surface_interface.cpp

Loading...