Differential D15904

Fix that dragging a file can trigger inline rename.
ClosedPublic
Actions

Authored by akrutzler on Oct 2 2018, 6:55 PM.

Details

Reviewers
wbauer
elvisangelaccio
ngraham
Group Reviewers
Dolphin
Commits
R318:ddfc86ab8c20: Fix that dragging a file can trigger inline rename.
Summary

Inline renaming is aborted as soon as an item is dragged. Previously, ’m_dragging' was used to determine if an item was being dragged. However, inline renaming is triggered after a certain amount of
time, during which time the user may have stopped dragging items.

BUG: 398375
FIXED-IN: 18.08.2

Test Plan

When dragging an selected item, inline renaming should never be started, regardless of where you drag it (Places panel, other split-view window, out of the Dolphin window, ...).

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
akrutzler created this revision.Oct 2 2018, 6:55 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptOct 2 2018, 6:55 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
akrutzler requested review of this revision.Oct 2 2018, 6:55 PM
This revision is now accepted and ready to land.Oct 2 2018, 7:50 PM
ngraham accepted this revision.Oct 2 2018, 10:44 PM
wbauer accepted this revision.Oct 3 2018, 8:09 AM

The patch seems to work fine, I was not able to trigger inline rename by dragging a file anymore.
Thank you!

Closed by commit R318:ddfc86ab8c20: Fix that dragging a file can trigger inline rename. (authored by akrutzler). · Explain WhyOct 3 2018, 6:08 PM
This revision was automatically updated to reflect the committed changes.
akrutzler added a comment.Oct 3 2018, 6:40 PM

Should I merge Applications/18.08 into master too?

ngraham added a comment.Oct 3 2018, 6:52 PM

Yes please!

Revision Contents
Changeset List

PathPackages
Msrc/views/dolphinview.cpp (5 lines)

Diff 42809

View Options

src/views/dolphinview.cpp

Loading...