| broulik |
| Frameworks |
Each notification was created as new datasource, and was newer removed
as long as the engine exists. This is especially bad for long living
applets like the device notifier. As there can only be one notification
per device (the last error state, or none), use the UDI as source name
and update the contents.
Also cancel (remove source) an old notifications in case of a successful
setup, otherwise old error messages are shown in the device notifier.
in Dolphin, select "Release" (context menu) for a mounted CD
-> Notification in device notifier appears "Device can be safely removed"
remount without ejecting
-> Notification message is removed, device shows "mounted" emblem.
Without the change, the message stayed and the device kept the notification
emblem "(!)".
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I think this makes sense
| dataengines/devicenotifications/devicenotificationsengine.cpp | ||
|---|---|---|
| 39 | This potentially breaks applets relying on the structure of that name? Not sure how big of an issue this is as far as "API promise" we give for dataengines but perhaps at least keep the notification part first | |
| dataengines/devicenotifications/devicenotificationsengine.h | ||
| 26 | Unused? | |
| dataengines/devicenotifications/ksolidnotify.cpp | ||
| 152 | Move this into the relevant case below, please | |
| dataengines/devicenotifications/devicenotificationsengine.cpp | ||
|---|---|---|
| 39 | The only user I could find is the device notifier, which relies on the contents of the container only for matching, and does not require any specific format for the source name. | |
| dataengines/devicenotifications/devicenotificationsengine.h | ||
| 26 | yes, leftover from a different approach. | |
| 42 | whitespace. | |
| dataengines/devicenotifications/ksolidnotify.cpp | ||
| 152 | I considered this and did not because of the early return. | |