Differential D15885

Clean UI file for `details` portion of UI
AbandonedPublic
Actions

Authored by bruns on Oct 1 2018, 4:40 PM.

Details

Reviewers
ngraham
davidedmundson
sharvey
Summary

Properly organized UI file (by @bruns)

Test Plan

Add to polkit-agent; recompile

Diff Detail

Repository
R121 Policykit (Polkit) KDE Agent
Branch
cleanup-ui (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3404
Build 3422: arc lint + arc unit
sharvey created this revision.Oct 1 2018, 4:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 1 2018, 4:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sharvey requested review of this revision.Oct 1 2018, 4:40 PM
davidedmundson accepted this revision.Oct 1 2018, 5:10 PM
This revision is now accepted and ready to land.Oct 1 2018, 5:10 PM
bruns added a comment.EditedOct 1 2018, 6:07 PM

The ui changes look fine now, but AFAICS you are missing the changes in AuthDialog.{h,cpp} from D12498 now.

I.e. the code is referencing app_label, which no longer exists after this change.

bruns requested changes to this revision.Oct 9 2018, 10:08 PM

Can you ammend this with the removals of appname/m_appname?
If you need any assistance, please ask!

This revision now requires changes to proceed.Oct 9 2018, 10:08 PM
bruns commandeered this revision.Oct 24 2018, 7:09 PM
bruns edited reviewers, added: sharvey; removed: bruns.
This revision is now accepted and ready to land.Oct 24 2018, 7:09 PM
bruns abandoned this revision.Oct 24 2018, 8:54 PM

Folded back into D12498

Revision Contents
Changeset List

PathPackages
Mauthdetails.ui (50 lines)

Diff 42679

View Options

authdetails.ui

Loading...