allow building with packagekit-qt >= 1.0.0
ClosedPublic

Authored by rikmills on Oct 1 2018, 11:17 AM.

Details

Summary

Currently fails to recognise packagekit-qt >= 1.0.0 with the message:
Could not find a configuration file for package "PackageKitQt5" that is compatible with requested version "0.9.5"
This results in the 'share' tab of Dolphin's folder properties simply
stating that samba is not installed, with the button which offers to
install this via packagekit not being present.
Currently known to affect at lease Kubuntu 18.04, 18.10, and Neon 18.04
packagekit-qt 0.9.5 dates from 2014, so regardless of more complicated
solutions, the version requirement can be dropped here.

BUG: 390599

Test Plan
  • Apply patch to Kubuntu CI builds of 18.08 branch.
  • Apply patch to eariler releases for potential bugfix in Kubuntu
  • Confirm that the button to install samba appears, installs samba, and that the samba sharing config options for the folder then appear.

Diff Detail

Repository
R432 File Sharing (Samba) integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rikmills requested review of this revision.Oct 1 2018, 11:17 AM
rikmills created this revision.

Test plan completed. Builds successfully with packagekit-qt 1.0.1 and restores expected functionality.

ngraham accepted this revision.Oct 4 2018, 2:57 AM

Yep, this fixes it for me too. Thanks!

This revision is now accepted and ready to land.Oct 4 2018, 2:57 AM
This revision was automatically updated to reflect the committed changes.