Gamut masking: mask rotation, advanced selector, tweaks
ClosedPublic

Authored by amedonosova on Sep 30 2018, 3:38 PM.

Details

Summary

This diff includes:

  • implementation for the advanced color selector (T9643),
  • common gamut masking toolbar for both advanced and artistic selectors (M135, M136),
  • mask rotation (as defined in T9642).

There are also some minor tweaks:

  • adaptive highlight of selected swatches - dark when the selected color is light, light when the selected color is dark;
  • gamut mask preview while editing is always on;
  • the blip in the artistic color selector is always on;
  • the text size of the comparative gray scale in the artistic selector is computed so it fits inside the rectangles.

Diff Detail

Repository
R37 Krita
Branch
amedonosova/gamut-masking
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3367
Build 3385: arc lint + arc unit
amedonosova created this revision.Sep 30 2018, 3:38 PM
Restricted Application added a project: Krita. · View Herald TranscriptSep 30 2018, 3:38 PM
amedonosova requested review of this revision.Sep 30 2018, 3:38 PM

I think what you have is great!

My only wish item for this is that the gamut mask state (on/off), gamut type (complimentary, etc), and rotation amount are saved in the KRA. If I start working on a painting and having a color gamut defined, I don't want to have to remember what gamut mask I set up last time. More than likely I will probably set it up not the same.

I think what you have is great!

Thanks. The slider was actually your idea and I think it works great :)

My only wish item for this is that the gamut mask state (on/off), gamut type (complimentary, etc), and rotation amount are saved in the KRA. If I start working on a painting and having a color gamut defined, I don't want to have to remember what gamut mask I set up last time. More than likely I will probably set it up not the same.

That's something I would also like. I have a task for it already, with some notes, T9652. I have not completed my analysis yet, it will take some time before it's ready for implementation. If you have any feedback or ideas, now or in the future, I will be grateful for them, as always.

rempt accepted this revision.Oct 2 2018, 7:22 AM
rempt added a subscriber: rempt.

Could we merge this today so it can be part of the 4.2 preview I want to do on Wednesday or Thursday?

This revision is now accepted and ready to land.Oct 2 2018, 7:22 AM
amedonosova edited the summary of this revision. (Show Details)Oct 2 2018, 7:39 AM
This revision was automatically updated to reflect the committed changes.