Differential D1586

Delay maximize button click to next event cycle
ClosedPublic
Actions

Authored by graesslin on May 11 2016, 11:45 AM.

Details

Reviewers

mart

Group Reviewers

Plasma

Commits

R108:6cd0d5a54acf: Delay maximize button click to next event cycle

Summary

The delay to next cycle dance is needed for Aurorae. Maximizing a
window can result in the decoration being destroyed, in which case
QtQuick can trigger a crash.

A test case is added to simulate the situation and ensure that maximize
still works also after the change.

BUG: 362772
FIXED-IN: 5.6.5

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 3758.May 11 2016, 11:45 AM

graesslin retitled this revision from to Delay maximize button click to next event cycle.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptMay 11 2016, 11:45 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart accepted this revision.May 12 2016, 11:28 AM

mart added a reviewer: mart.

This revision is now accepted and ready to land.May 12 2016, 11:28 AM

Closed by commit R108:6cd0d5a54acf: Delay maximize button click to next event cycle (authored by graesslin). · Explain WhyMay 12 2016, 2:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/wayland/CMakeLists.txt (11 lines)
A	M	autotests/wayland/dont_crash_aurorae_destroy_deco.cpp (155 lines)
M		clients/aurorae/themes/plastik/package/contents/ui/main.qml (1 line)
M		decorations/decoratedclient.h (4 lines)
M		decorations/decoratedclient.cpp (7 lines)