Details

Reviewers

tcanabrava
patrickelectric
laysrodrigues
leandrosantiago

Commits

R231:2e6a8847fd4c: Style adjust
R231:d280d82a550d: Use style icon as fallback for theme icon
R231:09749ed9168d: Set Version to 0.70.0 to reflect prerelease status
R231:63c33be56e67: Remove unused capture for lambda
R231:59650098f102: Clean up type warnings
R231:85194220a679: Warning Roundup
R231:ca4deb032601: Clean up warnings
R231:9dfaaeb02275: Clean warnings
R231:becc882d73a3: Clean up warnings
R231:56cc90b60294: Remove Warnings

Summary

Clean all warnings in project.
Style adjust for non conformed file
Set Version to 0.70.0 to reflect Prerelease status (from 1.0.0)

Diff Detail

Repository

R231 Atelier

Branch

smallthings

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3843
Build 3861: arc lint + arc unit

rizzitello requested review of this revision.Sep 30 2018, 3:05 PM

rizzitello created this revision.

Harbormaster completed remote builds in B3365: Diff 42601.Sep 30 2018, 3:06 PM

rizzitello retitled this revision from Remove unused capture for lambda to Warning Roundup.Sep 30 2018, 3:10 PM

rizzitello edited the summary of this revision. (Show Details)

rizzitello added reviewers: tcanabrava, patrickelectric, laysrodrigues, leandrosantiago.

rizzitello added a project: Atelier: AtCore.

rizzitello added a subscriber: Atelier: AtCore.

rizzitello edited projects, added Atelier: General Development; removed Atelier: AtCore.Sep 30 2018, 3:43 PM

rizzitello edited subscribers, added: Atelier: General Development; removed: Atelier: AtCore.

add isEqual method to make code more readable

Harbormaster completed remote builds in B3390: Diff 42650.Oct 1 2018, 10:08 AM

use std::max

Harbormaster completed remote builds in B3407: Diff 42693.Oct 1 2018, 8:31 PM

check for 0 before adding
Clean warnings

Harbormaster completed remote builds in B3445: Diff 42770.Oct 3 2018, 1:04 AM

why you are sending a float and casting it to double instead of passing everything as double?

Sith, there's two reviews with similar code, can you remove the duplications?
I don't understand why the amount of casting is needed.

src/dialogs/profilesdialog.cpp
57–58	QStringLiteral

In D15858#338053, @tcanabrava wrote:

Sith, there's two reviews with similar code, can you remove the duplications?
I don't understand why the amount of casting is needed.

The Casts are to remove compile time warnings of "Implicit casts" I have added the explicit casts to remove the warnings.

Add QStringLiteral

Harbormaster completed remote builds in B3572: Diff 43019.Oct 7 2018, 11:10 AM

rizzitello marked an inline comment as done.Oct 7 2018, 11:10 AM

tcanabrava added inline comments.Oct 7 2018, 11:19 AM

src/widgets/thermowidget.cpp
290–298	this can be a function outside of the thermo widget if we need to use it anywhere else. just a normal function, not a class method.

rizzitello marked an inline comment as done.Oct 7 2018, 11:22 AM

rizzitello added inline comments.

src/widgets/thermowidget.cpp
290–298	It could but its only needed here because the Qwt widget used here forces us to compare a bunch of doubles. This is not done elsewhere in the project.

rizzitello marked an inline comment as done.Oct 7 2018, 11:31 AM

tcanabrava accepted this revision.Oct 9 2018, 8:04 AM

This revision is now accepted and ready to land.Oct 9 2018, 8:04 AM

patrickelectric requested changes to this revision.Oct 10 2018, 12:00 PM

patrickelectric added inline comments.

src/widgets/3dview/fileloader.cpp
65	you can change perc itself to int, no ?
src/widgets/bedextruderwidget.cpp
50	Can we just change the thermo widget to emit ints ?
src/widgets/thermowidget.cpp
293	If a is -1 and b zero, this will fail.

This revision now requires changes to proceed.Oct 10 2018, 12:00 PM

Patrick's suggestions

Harbormaster completed remote builds in B3743: Diff 43352.Oct 10 2018, 8:50 PM

Target temperature can only be an int.

Harbormaster completed remote builds in B3747: Diff 43358.Oct 10 2018, 9:07 PM

laysrodrigues accepted this revision.Oct 13 2018, 2:08 PM

patrickelectric requested changes to this revision.Oct 13 2018, 6:23 PM

patrickelectric added inline comments.

src/widgets/thermowidget.cpp
261	Why you are not using int directly in xpos and ypos ?

This revision now requires changes to proceed.Oct 13 2018, 6:23 PM

Use int to avoid casts

Harbormaster completed remote builds in B3843: Diff 43552.Oct 13 2018, 7:17 PM

patrickelectric accepted this revision.Oct 13 2018, 7:23 PM

This revision is now accepted and ready to land.Oct 13 2018, 7:23 PM

rizzitello closed this revision.Oct 13 2018, 7:32 PM

			Path	Packages
M			CMakeLists.txt (4 lines)
M			src/dialogs/profilesdialog.cpp (11 lines)
M			src/mainwindow.cpp (2 lines)
M			src/widgets/3dview/fileloader.cpp (6 lines)
M			src/widgets/3dview/linemesh.cpp (8 lines)
M			src/widgets/atcoreinstancewidget.h (2 lines)
M			src/widgets/atcoreinstancewidget.cpp (6 lines)
M			src/widgets/bedextruderwidget.h (4 lines)
M			src/widgets/bedextruderwidget.cpp (16 lines)
M			src/widgets/thermowidget.h (5 lines)
M			src/widgets/thermowidget.cpp (70 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	42601	d73b93a		Sep 30 2018, 3:05 PM	★	★
Diff 2	42650	d73b93a	- add isEqual method to make code more readable	Oct 1 2018, 10:08 AM	★	★
Diff 3	42693	d73b93a	- use std::max	Oct 1 2018, 8:31 PM	★	★
Diff 4	42770	d73b93a	- check for 0 before adding	Oct 3 2018, 1:04 AM	★	★
Diff 5	43019	d73b93a	- Add QStringLiteral	Oct 7 2018, 11:10 AM	★	★
Diff 6	43352	d73b93a	- Patrick's suggestions	Oct 10 2018, 8:50 PM	★	★
Diff 7	43358	d73b93a	- Target temperature can only be an int.	Oct 10 2018, 9:07 PM	★	★
Diff 8	43552	d73b93a	- Use int to avoid casts	Oct 13 2018, 7:17 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
9dfaaeb02275	3bf19f75c70f	56cc90b60294	Chris Rizzitello	Clean warnings (Show More…)	Sep 30 2018, 3:02 PM
56cc90b60294	daef67702726	ca4deb032601	Chris Rizzitello	Remove Warnings (Show More…)	Sep 30 2018, 2:28 PM
ca4deb032601	32222057d609	becc882d73a3	Chris Rizzitello	Clean up warnings (Show More…)	Sep 30 2018, 2:57 PM
becc882d73a3	ab31ebf03cfa	d280d82a550d	Chris Rizzitello	Clean up warnings (Show More…)	Sep 30 2018, 12:50 PM
d280d82a550d	595abfc8c784	09749ed9168d	Chris Rizzitello	Use style icon as fallback for theme icon (Show More…)	Sep 30 2018, 12:43 PM
09749ed9168d	e444f46e60be	2e6a8847fd4c	Chris Rizzitello	Set Version to 0.70.0 to reflect prerelease status (Show More…)	Sep 30 2018, 12:30 PM
2e6a8847fd4c	45d3dcf85273	59650098f102	Chris Rizzitello	Style adjust (Show More…)	Sep 30 2018, 12:26 PM
59650098f102	5b86484f9d68	63c33be56e67	Chris Rizzitello	Clean up type warnings (Show More…)	Sep 30 2018, 1:54 AM
63c33be56e67	c607867067cc	d73b93a76eda	Chris Rizzitello	Remove unused capture for lambda (Show More…)	Sep 30 2018, 1:37 AM

Warning Roundup
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 43552

CMakeLists.txt

src/dialogs/profilesdialog.cpp

src/mainwindow.cpp

src/widgets/3dview/fileloader.cpp

src/widgets/3dview/linemesh.cpp

src/widgets/atcoreinstancewidget.h

src/widgets/atcoreinstancewidget.cpp

src/widgets/bedextruderwidget.h

src/widgets/bedextruderwidget.cpp

src/widgets/thermowidget.h

src/widgets/thermowidget.cpp

Warning RoundupClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 43552

CMakeLists.txt

src/dialogs/profilesdialog.cpp

src/mainwindow.cpp

src/widgets/3dview/fileloader.cpp

src/widgets/3dview/linemesh.cpp

src/widgets/atcoreinstancewidget.h

src/widgets/atcoreinstancewidget.cpp

src/widgets/bedextruderwidget.h

src/widgets/bedextruderwidget.cpp

src/widgets/thermowidget.h

src/widgets/thermowidget.cpp

Warning Roundup
ClosedPublic
Actions

Revision Contents
Changeset List