Differential D15857

Port Kalzium away from KDialog KFileDialog and deprecated KRun::runUrl
ClosedPublic
Actions

Authored by yurchor on Sep 30 2018, 2:01 PM.

Details

Reviewers

cfeck

Group Reviewers

KDE Edu

Commits

R326:4ee2eb30fb60: Port Kalzium away from KDialog KFileDialog and deprecated KRun::runUrl

Summary

Some things are deprecated now so it can be worth to port from them.

Test Plan

Use "File->Convert chemical files..." and "Add" button to test the port from KDialog and KFileDialog.
Use tools from the "Tools" menu (esp. "Molecular Editor" and the "Load Molecule" button).
Double-click on the element in the table and switch to the "Extra information" tab to test the runUrl port.
Everything should work as in the unported version.

Diff Detail

Repository

R326 Kalzium

Lint

Lint Skipped

Unit

Unit Tests Skipped

yurchor created this revision.Sep 30 2018, 2:01 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptSep 30 2018, 2:01 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

yurchor requested review of this revision.Sep 30 2018, 2:01 PM

+1 good job!

src/tools/obconverter.cpp
257	Indentation is 4 spaces elsewhere.

Fix indentation and includes

Fix whitespaces

yurchor marked an inline comment as done.Sep 30 2018, 6:09 PM

Hi again,

What can I fix in this revision to make it acceptable?

Thanks in advance for your reviews.

Such big changes are hard to review. We used to do KF5 porting step by step, i.e. replace one include or one class in a single commit.

Regarding the new connect() calls, could they get converted to new style connects?

This revision is now accepted and ready to land.Oct 17 2018, 10:58 PM

In D15857#345029, @cfeck wrote:

Such big changes are hard to review. We used to do KF5 porting step by step, i.e. replace one include or one class in a single commit.

Sorry for such big changes. The only excuse that they are purely routine (almost the results of the automatic conversion) not saying about three major points:

Correct connections for userButtons.
Correct help invocation (it is only possible to open the main page of Kalzium help page, but it's a KF5 kiohelp bug).
Correct opening of molecule files by Avogadro viewer.

If those three are acceptable the whole patch must be at least close to acceptable.

That's why I decided to make just one patch from this.

If you think that it is better to split this patch for further reviewing I can do this.

Regarding the new connect() calls, could they get converted to new style connects?

Sure. Should be done in the next iteration. Should there are no objections to the new patch version (tested again locally) I can commit it on Sunday (2018-10-21).

Thanks again for your reviews.

Rewrite connect() in the new style where I touched the code, a couple of minor tweaks.

Pushed:

https://cgit.kde.org/kalzium.git/commit/?id=4ee2eb30fb60bc1e2e5393eb56bf5bdefbdfb4e2

Revision Contents
Changeset List

			Path	Packages
M			plasmoid/applet/bodr/kalzium_plasma.h (4 lines)
M			plasmoid/applet/bodr/kalzium_plasma.cpp (31 lines)
M			plasmoid/applet/concentrationPlasmoid/concentrationCalculator.cpp (7 lines)
M			plasmoid/applet/gasPlasmoid/gasCalculator.cpp (7 lines)
M			plasmoid/applet/nuclearPlasmoid/kalziumdataobject.cpp (2 lines)
M			plasmoid/applet/nuclearPlasmoid/nuclearCalculator.cpp (7 lines)
M			plasmoid/applet/psePlasmoid/Molmasscalculator.cpp (28 lines)
M			src/calculator/calculator.h (4 lines)
M			src/calculator/calculator.cpp (34 lines)
M			src/detailinfodlg.h (1 line)
M			src/detailinfodlg.cpp (8 lines)
M			src/elementdataviewer.h (4 lines)
M			src/elementdataviewer.cpp (70 lines)
M			src/eqchemview.cpp (2 lines)
M			src/exportdialog.h (9 lines)
M			src/exportdialog.cpp (48 lines)
M			src/isotopetable/isotopeitem.cpp (2 lines)
M			src/isotopetable/isotopetabledialog.h (4 lines)
M			src/isotopetable/isotopetabledialog.cpp (24 lines)
M			src/kalzium.cpp (5 lines)
M			src/kalziumelementproperty.cpp (2 lines)
M			src/kalziumgradienttype.cpp (2 lines)
M			src/kalziumnumerationtype.cpp (2 lines)
M			src/kalziumschemetype.cpp (4 lines)
M			src/kalziumutils.cpp (2 lines)
M			src/kdeeduglossary.h (4 lines)
M			src/kdeeduglossary.cpp (55 lines)
M			src/legendwidget.h (2 lines)
M			src/legendwidget.cpp (4 lines)
M			src/molcalcwidget.cpp (2 lines)
M			src/psetable/elementitem.cpp (2 lines)
M			src/psetable/numerationitem.cpp (2 lines)
M			src/rsdialog.h (4 lines)
M			src/rsdialog.cpp (23 lines)
M			src/spectrumwidget.cpp (1 line)
M			src/tableinfowidget.h (2 lines)
M			src/tablesdialog.cpp (5 lines)
M			src/tools/moleculeview.h (4 lines)
M			src/tools/moleculeview.cpp (77 lines)
M			src/tools/obconverter.h (9 lines)
M			src/tools/obconverter.cpp (66 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	42598		Sep 30 2018, 1:52 PM	★	★
Diff 2	42613		Sep 30 2018, 4:59 PM	★	★
Diff 3	42619		Sep 30 2018, 6:08 PM	★	★
Diff 4	43867		Oct 18 2018, 1:42 PM	★	★

Port Kalzium away from KDialog KFileDialog and deprecated KRun::runUrlClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 43867

plasmoid/applet/bodr/kalzium_plasma.h

plasmoid/applet/bodr/kalzium_plasma.cpp

plasmoid/applet/concentrationPlasmoid/concentrationCalculator.cpp

plasmoid/applet/gasPlasmoid/gasCalculator.cpp

plasmoid/applet/nuclearPlasmoid/kalziumdataobject.cpp

plasmoid/applet/nuclearPlasmoid/nuclearCalculator.cpp

plasmoid/applet/psePlasmoid/Molmasscalculator.cpp

src/calculator/calculator.h

src/calculator/calculator.cpp

src/detailinfodlg.h

src/detailinfodlg.cpp

src/elementdataviewer.h

src/elementdataviewer.cpp

src/eqchemview.cpp

src/exportdialog.h

src/exportdialog.cpp

src/isotopetable/isotopeitem.cpp

src/isotopetable/isotopetabledialog.h

src/isotopetable/isotopetabledialog.cpp

src/kalzium.cpp

src/kalziumelementproperty.cpp

src/kalziumgradienttype.cpp

src/kalziumnumerationtype.cpp

src/kalziumschemetype.cpp

src/kalziumutils.cpp

src/kdeeduglossary.h

src/kdeeduglossary.cpp

src/legendwidget.h

src/legendwidget.cpp

src/molcalcwidget.cpp

src/psetable/elementitem.cpp

src/psetable/numerationitem.cpp

src/rsdialog.h

src/rsdialog.cpp

src/spectrumwidget.cpp

src/tableinfowidget.h

src/tablesdialog.cpp

src/tools/moleculeview.h

src/tools/moleculeview.cpp

src/tools/obconverter.h

src/tools/obconverter.cpp

Port Kalzium away from KDialog KFileDialog and deprecated KRun::runUrl
ClosedPublic
Actions

Revision Contents
Changeset List