Allow removing non-existent folders from include and exclude lists
ClosedPublic

Authored by ngraham on Sep 29 2018, 10:52 PM.

Details

Summary

Currently, if you add a folder to Baloo's includeFolders or excludeFolders lists, it cannot be removed again if it has been deleted. This patch fixes that for both balooctl and also the KCM.

BUG: 375370
FIXED-IN: 5.51

Test Plan
mkdir ~/foobar-test
balooctl config add excludeFolders ~/foobar-test
rmdir ~/foobar-test
balooctl config remove excludeFolders ~/foobar-test

Without the patch, balooctl exits with an error, reports "Path does not exist", and does not remove the entry.

With the patch, balooctl exits cleanly with no error and removes the path.

Works from the KCM, too.

Diff Detail

Repository
R293 Baloo
Branch
fix-removing-locations-from-include-and-exclude-lists (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3346
Build 3364: arc lint + arc unit
ngraham created this revision.Sep 29 2018, 10:52 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptSep 29 2018, 10:52 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Sep 29 2018, 10:52 PM
ngraham edited the summary of this revision. (Show Details)Sep 29 2018, 10:53 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham updated this revision to Diff 42574.Sep 29 2018, 10:57 PM

Don't unnecessarily rename the variable

bruns accepted this revision.Sep 29 2018, 11:08 PM
This revision is now accepted and ready to land.Sep 29 2018, 11:08 PM
ngraham closed this revision.Sep 29 2018, 11:12 PM