Remove useless "No X-KDE-DBus-ServiceName found" message
ClosedPublic

Authored by bruns on Sep 29 2018, 9:41 PM.

Details

Summary

None of the KDED modules provide a X-KDE-DBus-ServiceName, so there are
a lot of warnings during session startup.
Not providing the entry actually is no error, as:

  1. modules are loaded and requested using the org.kde.kded5 service
  2. org.kde.kded5 already is a singleton, so protecting against multiple

instances of the module is not necessary.

Test Plan

make

Diff Detail

Repository
R297 KDED
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Sep 29 2018, 9:41 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 29 2018, 9:41 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Sep 29 2018, 9:41 PM
bruns added a comment.Oct 15 2018, 2:17 PM

The current state causes unnecessary log spam, would be good to have this in.

davidedmundson accepted this revision.Oct 24 2018, 6:56 PM

If it's not a requirement for it to be set (and it isn't) I agree it's not a useful warning. But it's also not remotely useful debug.

It's easy to see when something is registered, and we still have a warning if registration fails.

Just delete it.

This revision is now accepted and ready to land.Oct 24 2018, 6:56 PM
bruns updated this revision to Diff 44172.Oct 24 2018, 7:02 PM
bruns retitled this revision from Lower log level for X-KDE-DBus-ServiceName missing message to Remove useless "No X-KDE-DBus-ServiceName found" message.

Completely remove message

This revision was automatically updated to reflect the committed changes.