extend test coverage to all supported mimetypes for taglibextractor
ClosedPublic
Actions

Authored by astippich on Sep 29 2018, 2:05 PM.

Details

Reviewers

mgallien
bruns
svuorela

Commits

R286:601059a3c0b6: extend test coverage to all supported mimetypes for taglibextractor

Summary

Add new test files such that all mime types declared as
supported by the taglibextractor are actually tested.
The new test files were created from the existing files
and converted with ffmpeg or the official Monkey's
Audio encoder, which is free for any usage.

Test Plan

new tests pass

Diff Detail

Repository

R286 KFileMetaData

Branch

taglib_extractor_additional_tests

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3579
Build 3597: arc lint + arc unit

astippich created this revision.Sep 29 2018, 2:05 PM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptSep 29 2018, 2:05 PM

Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript

astippich requested review of this revision.Sep 29 2018, 2:05 PM

Harbormaster completed remote builds in B3331: Diff 42549.Sep 29 2018, 2:05 PM

astippich added a dependency: D15825: move testing of common tags of test files to a new data-driven test for taglibextractor.Sep 29 2018, 2:05 PM

modify permissions of binary files

Harbormaster completed remote builds in B3333: Diff 42551.Sep 29 2018, 2:10 PM

What's the origin/license of these files ? How are they created ?

In D15833#333933, @svuorela wrote:

What's the origin/license of these files ? How are they created ?

The files contain just silence.

@astippich - can you convert the wav file to 8bit (32bit float currently), so it becomes smaller. Same for aiff, probably.

Please lower bitdepth.
Also, can you provide the commandline or the like to generate the files? - probably this is also stuff for an accompanying README file.

This revision now requires changes to proceed.Sep 30 2018, 2:15 AM

astippich mentioned this in D15825: move testing of common tags of test files to a new data-driven test for taglibextractor.Oct 7 2018, 12:30 PM

astippich edited the summary of this revision. (Show Details)Oct 7 2018, 12:35 PM

In D15833#333933, @svuorela wrote:

What's the origin/license of these files ? How are they created ?

Forgot to mention it, I added this information to the summary.

In D15833#333944, @bruns wrote:

In D15833#333933, @svuorela wrote:

What's the origin/license of these files ? How are they created ?

The files contain just silence.

@astippich - can you convert the wav file to 8bit (32bit float currently), so it becomes smaller. Same for aiff, probably.

Good idea, will update.

In D15833#334084, @bruns wrote:

Please lower bitdepth.
Also, can you provide the commandline or the like to generate the files? - probably this is also stuff for an accompanying README file.

I went the stupid way and converted them from the existing files, so I didn't really generate them.

update aiff and wav test files so that they are smaller

Harbormaster completed remote builds in B3579: Diff 43031.Oct 7 2018, 1:05 PM

Thx!

This revision is now accepted and ready to land.Oct 8 2018, 6:38 PM

Closed by commit R286:601059a3c0b6: extend test coverage to all supported mimetypes for taglibextractor (authored by astippich). · Explain WhyOct 10 2018, 4:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path
A	M	(bin)	autotests/samplefiles/test.aif
A	M	(bin)	autotests/samplefiles/test.ape
A	M	(bin)	autotests/samplefiles/test.wav
A	M	(bin)	autotests/samplefiles/test.wv
M			autotests/taglibextractortest.cpp (20 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	42549	e521abb		Sep 29 2018, 2:05 PM	★	★
Diff 2	42551	e521abb	- modify permissions of binary files	Sep 29 2018, 2:10 PM	★	★
Diff 3	43031	f7a6f6a	- update aiff and wav test files so that they are smaller	Oct 7 2018, 1:05 PM	★	★
Diff 4	43325	52920c0	R286:601059a3c0b6e96dc5e8193afdfb1645bc2122e5	Oct 10 2018, 4:30 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
fd233e88ffef	2ca5bcc39eb7	062e612f92e1	Alexander Stippich	update aiff and wav test files so that they are smaller	Oct 7 2018, 1:03 PM
062e612f92e1	9f3bea25f1de	5cc657d663b6	Alexander Stippich	modify permissions of binary files	Sep 29 2018, 2:10 PM
5cc657d663b6	cef38741097d	f7a6f6aa3811	Alexander Stippich	extend test coverage to all supported mimetypes for taglibextractor (Show More…)	Sep 29 2018, 1:39 PM

	Status	Author	Revision
	Closed	astippich	D15833 extend test coverage to all supported mimetypes for taglibextractor
	Closed	astippich	D15825 move testing of common tags of test files to a new data-driven test for taglibextractor