If the hardware reports "internal" as formfactor the generic audio-card icon is chosen. Instead look whether the device is a sink/source and display a more specific icon.
Before:
After:
Diff Detail
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Branch
- icons
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 3318 Build 3336: arc lint + arc unit
Comment Actions
+10 on the end goal of showing speaker or microphone icons instead of a generic sound card icon! I'm not sure this is the best way to achieve that though. I'm sure @drosca will be able to offer some guidance here.
Comment Actions
Possibly related information: I believe the original change that resulted in sound card icons everywhere was D8054. In particular, read https://phabricator.kde.org/D8054#252877.
Comment Actions
I don't really think it looks better, now you have those icons duplicated (big one being for the "device" and small one in volume slider). I think it would be much better to have new icon for "speakers" and "microphone" devices instead of using "output-volume" and "input-volume" icons.
Comment Actions
I think showing a generic speaker or microphone icon is a huge visual improvement over a sound card, but I agree with @drosca that it's odd to duplicate them.
Here's an idea: It's completely obvious what the sliders are for, so just get rid of the little ones:
Comment Actions
I think showing a generic speaker or microphone icon is a huge visual improvement over a sound card, but I agree with @drosca that it's odd to duplicate them.
Here's an idea: It's completely obvious what the sliders are for, so just get rid of the little ones:
The little ones also act as buttons for muting. If we want to keep that functionality we could incorporate this into the big ones
Comment Actions
Great idea. Then the click target becomes much bigger and muting is easier. If we do that, we'd probably want to badge the icon with emblem-unavailable so that it's clear that that stream is muted.