[Folder View] Fix right/left arrow navigation in popup mode
ClosedPublic

Authored by thsurrel on Sep 28 2018, 9:12 PM.

Details

Summary

This patch fixes several issues in the popup mode:

  • when using the Folder View in 'Icon mode', pressing the right arrow when on a folder would enter that folder instead of just moving the selection to the right
  • when using the Folder View in 'list mode', navigating in a subfolder and pressing the right arrow several times while selection is on a file would result in having to press an equal number of times the left arrow before it navigates back to the parent folder
  • using the left arrow now only navigates back. Pressing the left arrow while in the 'root' folder of the Folder View was also moving the selection up, which is inconsistent

Diff Detail

Repository
R119 Plasma Desktop
Branch
arc_folderview2 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3315
Build 3333: arc lint + arc unit
thsurrel created this revision.Sep 28 2018, 9:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 28 2018, 9:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
thsurrel requested review of this revision.Sep 28 2018, 9:12 PM
thsurrel retitled this revision from [Folder View] Fix right/left arrow navigation in popup + list view mode to [Folder View] Fix right/left arrow navigation in popup mode.Oct 2 2018, 12:47 PM
thsurrel edited the summary of this revision. (Show Details)
thsurrel added a reviewer: hein.
hein accepted this revision.Oct 6 2018, 1:03 AM
This revision is now accepted and ready to land.Oct 6 2018, 1:03 AM
This revision was automatically updated to reflect the committed changes.