Add icon to compress/extract actions
ClosedPublic

Authored by nicolasfella on Sep 27 2018, 4:41 PM.

Diff Detail

Repository
R36 Ark
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6119
Build 6137: arc lint + arc unit
nicolasfella created this revision.Sep 27 2018, 4:41 PM
Restricted Application added a project: Ark. · View Herald TranscriptSep 27 2018, 4:41 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
nicolasfella requested review of this revision.Sep 27 2018, 4:41 PM
nicolasfella edited the summary of this revision. (Show Details)Sep 27 2018, 4:42 PM

Can you perhaps provide a screenshot with Breeze iconset?

There's an archive-extract icon in Breeze, maybe we need some action icon rather than using Ark's icon? Being the only colorful icon (besides the "Open" application icon) makes it stick out imho

The archive-* icons are not the best-looking IMHO. I'm not against using them to preserve the monochrome nature of the menu icons, but I think in that case they'll need some work.

I also think we should use monochrome icons there.

I agree that a monochrome icon is better.
archive-extract could use some redesign indeed. I don't see any monochrome compress icon at all.

Let's track improving the icon with a Bugzilla ticket so we don't clutter this up: https://bugs.kde.org/show_bug.cgi?id=399253

Probably the archive-insert icon is the most appropriate one to use for now, and then hopefully it will look better once https://bugs.kde.org/show_bug.cgi?id=399253 is done.

We now have better icons that we should use instead: D16964

Use new icons

nicolasfella edited the summary of this revision. (Show Details)Dec 18 2018, 1:49 AM
ngraham accepted this revision.Dec 18 2018, 4:44 AM

+1 shipit!

This revision is now accepted and ready to land.Dec 18 2018, 4:44 AM
elvisangelaccio accepted this revision.Dec 19 2018, 8:46 PM
This revision was automatically updated to reflect the committed changes.