KDEInstallDirs.cmake used the deprecated format for install dirs internally and thus caused a bunch of warnings, which are fixed by this patch.
Diff Detail
Diff Detail
- Repository
- R240 Extra CMake Modules
- Lint
Lint Skipped - Unit
Unit Tests Skipped
kde-modules/KDEInstallDirs.cmake | ||
---|---|---|
564 | I'm going to comment only on this, but the others (most, if not all) are the same. If you check the definition of _define_relative, this parameter is: oldstylename (optional): the old-style name of the variableSo this command is exactly defining the old variable in addition to the new one. Unless of course I misunderstood the code... |
kde-modules/KDEInstallDirs.cmake | ||
---|---|---|
564 | Hmm, you're right, but then it shouldn't come up with a warning...? In the _define_relative macro we have: if(KDE_INSTALL_${varname}) ... elseif(${_oldstylename}) if(NOT CMAKE_VERSION VERSION_LESS 3.0.0) message(DEPRECATION "${_oldstylename} is deprecated, use KDE_INSTALL_${varname} instead.") In my case the message was triggered for all definitions. |
Comment Actions
The warning needs to be removed then. We can't really warn at the time of using a variable.