Log wallet open failure errors
ClosedPublic

Authored by arjun on Sep 26 2018, 5:30 PM.

Details

Summary

Hopefully this would end up on syslog and grab the attention of the sysadmin.

Diff Detail

Repository
R311 KWallet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arjun created this revision.Sep 26 2018, 5:30 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 26 2018, 5:30 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
arjun requested review of this revision.Sep 26 2018, 5:30 PM
mlaurent requested changes to this revision.Sep 27 2018, 5:11 AM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
src/runtime/kwalletd/kwalletd.cpp
685

Use :
qCWarning(KWALLETD_LOG) ...

This revision now requires changes to proceed.Sep 27 2018, 5:11 AM
arjun updated this revision to Diff 42430.Sep 27 2018, 3:38 PM
arjun removed a reviewer: mlaurent.
arjun marked an inline comment as done.
arjun added a reviewer: mlaurent.
mlaurent accepted this revision.Sep 28 2018, 8:44 AM
This revision is now accepted and ready to land.Sep 28 2018, 8:44 AM
arjun added a comment.Sep 28 2018, 6:34 PM

I don't see a merge button, Am i supposed to push it via git?

bruns added a subscriber: bruns.Sep 28 2018, 7:32 PM

The preferred way is to use arc, i.e. arc diff, ..., arc land, which ensures phabricator tags (Reviewed:, Revision, ...) are added to the commit message.

src/runtime/kwalletd/kwalletd.cpp
685

nitpick - qCWarning(..) add spaces between arguments by default, so there is a double space between "wallet" and <wallet>

This revision was automatically updated to reflect the committed changes.
arjun marked an inline comment as done.Sep 29 2018, 7:19 AM

The preferred way is to use arc, i.e. arc diff, ..., arc land, which ensures phabricator tags (Reviewed:, Revision, ...) are added to the commit message.

My distro doesn't ship arc, I've manually added the tags.