Show the preferred resolution on the combo box
ClosedPublic

Authored by apol on Wed, Sep 26, 3:07 PM.

Details

Summary

Usually there's a preferred resoluton for a display, let the user know it

Test Plan

Used the kcm with it, it's shown.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Wed, Sep 26, 3:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Sep 26, 3:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Wed, Sep 26, 3:07 PM
davidedmundson accepted this revision.Wed, Sep 26, 4:09 PM
davidedmundson added a subscriber: davidedmundson.

Code is neater. I like that.

Don't have an opinion on the icon, maybe tag VDG.

kcm/src/resolutionslider.cpp
71

I know you're not changing this, but this is rather broken.

You might have only a current mode or a preferred mode or both.

If you have both which one ends up selected by default is effectively arbitrary based on insertion order. (would require a monitor with a preferred mode that's smaller than the mode the user chose...but could happen I think?)

This revision is now accepted and ready to land.Wed, Sep 26, 4:09 PM

I think the favorite icon is just fine. 👍

Closed by commit R104:dfd178e6d093: Show the preferred resolution on the combo box (authored by Your Name <you@example.com>, committed by apol). · Explain WhyFri, Sep 28, 4:34 PM
This revision was automatically updated to reflect the committed changes.