Show "muted" icon in panel and disable shortcuts for Dummy Output
ClosedPublic

Authored by broulik on Sep 26 2018, 2:12 PM.

Details

Summary

The "Dummy Output" doesn't play any sound, so indicate that in the panel.
Also disable the volume shortcuts in this case.

Test Plan

The slider in the popup alongside "Dummy Output" is still there and can be interacted with, should an application rely on the fact that it's not muted or something like that? Can still be addressed separately

  • Disconnected my headphones. Got an OSD saying "dummy output" is now the current device and my panel showed a constant "muted" icon, pressing volume keys or wheeling the icon would do nothing
  • Connected my headphones. Tray icon reflected default output volume, pressing volume keys and wheeling the icon would change the volume

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Sep 26 2018, 2:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 26 2018, 2:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 26 2018, 2:12 PM
drosca accepted this revision.Sep 26 2018, 2:47 PM
This revision is now accepted and ready to land.Sep 26 2018, 2:47 PM
This revision was automatically updated to reflect the committed changes.